XingfenD
dd5d0fabf9
P15-A merged to crearte-server master as e70e99b (0.19.0, merge-base fe810dd, eight commits on the branch). Both review rounds came back with notes and both caught the controller's own verification method rather than the refactor: the gofmt gate in the shared four-gate recipe was exit-code blind, and identifier counting cannot prove behaviour is unchanged (whole files rather than function bodies, a hand-picked list read as a universal claim, and no visibility into control flow at all). The branch review's most valuable contribution was an evidence layer all four earlier runs had silently skipped: the five real-database guards the spec names were SKIPPED everywhere because nobody set TEST_DATABASE_URL, and the ~11s internal/api timing reported as "including real-database integration" was the mock path. Running postgres against both trees gave base 194 PASS versus HEAD 199 PASS with identical state multisets - the first runtime proof of unchanged behaviour on the production database path. Five of its notes concerned controller artefacts, not code. Four were spec staleness introduced during re-pin, every one from writing executable details from memory instead of grepping them out of the code; the fifth was the fake-rigour form of the vacuous-assertion defect this project keeps finding - a verification script printing nineteen [OK] lines with no checking logic behind them while citing an output file that was never archived. Both are now fixed in37a0a8dand9061c39, and the lesson is a spec discipline: executable details in a spec must be grepped from the code entity and pasted, never hand-written. ROADMAP also gains a correction of my own omission: P15-A and P15-B were registered in the document index but never added to the third-wave status table, which still ended at P14. P15-B is deliberately excluded from this entry. Its branch review returned "needs fixing before merge" - the second time a branch review has blocked a batch after P11 - on a critical gap in the guard layer: maskSourceComments() compares a two-character slice against the four-character '<!--', so its HTML comment branch is dead code. A second fix-forward is in flight; P15-B books as 0.3.9 when it merges.