fix(handlers): Upload io.Copy error → 500 not 413 (B6), Me distinguishes no-rows from DB errors (B7)

This commit is contained in:
2026-09-14 19:42:25 +08:00
parent b82a891c50
commit 0e62d4aa18
2 changed files with 14 additions and 2 deletions
+5
View File
@@ -48,10 +48,15 @@ func (h *H) Login(c *gin.Context) {
} }
func (h *H) Me(c *gin.Context) { func (h *H) Me(c *gin.Context) {
// B7: only no-rows → 401; other errors (PG down) go through dbErr → 503.
u, qerr := h.st.GetUserByID(c, uid(c)) u, qerr := h.st.GetUserByID(c, uid(c))
if qerr != nil { if qerr != nil {
if errors.Is(qerr, pgx.ErrNoRows) {
err(c, http.StatusUnauthorized, "unauthorized", "no such user") err(c, http.StatusUnauthorized, "unauthorized", "no such user")
return return
} }
dbErr(c, qerr)
return
}
c.JSON(http.StatusOK, gin.H{"id": u.ID, "username": u.Username, "role": u.Role}) c.JSON(http.StatusOK, gin.H{"id": u.ID, "username": u.Username, "role": u.Role})
} }
+8 -1
View File
@@ -146,10 +146,17 @@ func (h *H) Upload(c *gin.Context) {
err(c, http.StatusInternalServerError, "internal", "create tmp") err(c, http.StatusInternalServerError, "internal", "create tmp")
return return
} }
// B6: only MaxBytesError returns 413; other io.Copy failures (disk full,
// connection drop) return 500.
if _, e := io.Copy(out, src); e != nil { if _, e := io.Copy(out, src); e != nil {
out.Close() out.Close()
os.Remove(tmp) os.Remove(tmp)
err(c, http.StatusRequestEntityTooLarge, "too_large", "upload failed") var mbe *http.MaxBytesError
if errors.As(e, &mbe) {
err(c, http.StatusRequestEntityTooLarge, "too_large", "file exceeds upload limit")
return
}
err(c, http.StatusInternalServerError, "internal", "upload failed")
return return
} }
out.Close() out.Close()